[HttpKernel] Additional HTTP exceptions

[ramsey]

I wanted to continue using exceptions for many other types of HTTP 4xx and 5xx status codes, particularly because I like the notion that I can trap the exception based on the type, rather than inspecting HttpException to see what status code it contains. I've decided to contribute these back to the Symfony HttpKernel component, in case others find them useful.

• Bug fix: no
• Feature addition: yes
• Backwards compatibility break: no
• Symfony2 tests pass: yes
• Fixes the following tickets: -
• Todo: -
• License of the code: MIT
• Documentation PR: n/a

This pull request provides the following new HttpKernel Exceptions:

Exception	Applicable HTTP Status Code
BadRequestHttpException	400 Bad Request
ConflictHttpException	409 Conflict
GoneHttpException	410 Gone
InternalServerErrorHttpException	500 Internal Server Error
LengthRequiredHttpException	411 Length Required
NotAcceptableHttpException	406 Not Acceptable
PreconditionFailedHttpException	412 Precondition Failed
PreconditionRequiredHttpException	428 Precondition Required†
ServiceUnavailableHttpException	503 Service Unavailable
TooManyRequestsHttpException	429 Too Many Requests†
UnauthorizedHttpException	401 Unauthorized
UnsupportedMediaTypeHttpException	415 Unsupported Media Type

All the tests have been placed in the FlattenExceptionTest, since that's where the previous status code and method tests for HttpException exceptions are located, but I can move them to a more logical location, if needed.

† These codes have been included from RFC 6585, Additional HTTP Status Codes.

[travisbot]

This pull request passes (merged d4e234f into 7a233bc).

[stof]

I would remove the InternalServerError one, as you get a 500 for any non-http exception anyway

[stof]

and please rebase your branch to get rid of the merge commit at the beginning of your PR

[ramsey]

@stof Can you provide some pointers on how to get rid of the merge commit through a rebase? I generally avoid rebase, so doing this is fairly new to me. I realize that what created the commit was a non-fast-forward merge, so I just need to understand how to get it to apply merges cleanly without creating merge commits like that. Thanks!

[alexandresalome]

@ramsey

# suppose you are on branch-feature
# given origin is the symfony repository
git pull --rebase origin/master

# equivalent to
git fetch origin
git rebase origin/master

If you want to rebase your branch on 2.1:

git pull --rebase origin/2.1

[stof]

@ramsey http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch for the documentation about the way to do it

[stof]

@ramsey ping

[fabpot]

I'm going to finish this PR, but #5862 should be merged first.

[ramsey]

Sorry I've been sitting on this for so long. I haven't had time to figure out how to get rid of the merge commit, as @stof requested. That's the only outstanding issue here, as far as I know.

[fabpot]

I can see another issue. For some HTTP codes, you can/should/must add some headers or some content (like for the 406 status code).

Don't worry about the merge commit or the rebasing, I will take care of that myself when merging the PR.

[ramsey]

I don't know what header is required for the 406 status code. RFC 2616 doesn't specify one. It does say "the response should include an entity containing a list of available entity characteristics and locations."

In other exceptions, such as UnauthorizedHttpException, TooManyRequestsHttpException, and ServiceUnavailableException, I did provide the required headers.

On Monday, October 29, 2012 at 10:48 AM, Fabien Potencier wrote:

I can see another issue. For some HTTP codes, you can/should/must add some headers or some content (like for the 406 status code).
Don't worry about the merge commit or the rebasing, I will take care of that myself when merging the PR.

—
Reply to this email directly or view it on GitHub (#5312 (comment)).

[fabpot]

merged, thanks.

[ramsey]

Thanks!