Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for not displaying a form-label by setting label to false. #5421

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@BenjaminBeck
Copy link
Contributor

commented Sep 3, 2012

....twig

Option for not displaying a label by setting label to false.

BenjaminBeck added some commits Sep 3, 2012

Update src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.h…
…tml.twig

Option for not displaying a label by setting label to false.
@travisbot

This comment has been minimized.

Copy link

commented Sep 3, 2012

This pull request fails (merged 07a111e into 41ffd00).

@stof

This comment has been minimized.

Copy link
Member

commented Sep 3, 2012

The same should be done for the PHP rendering

@stof

This comment has been minimized.

Copy link
Member

commented Sep 3, 2012

and this is breaking a lots of tests

@travisbot

This comment has been minimized.

Copy link

commented Sep 3, 2012

This pull request passes (merged 9a06f29 into 41ffd00).

@stof

This comment has been minimized.

Copy link
Member

commented Oct 13, 2012

@BenjaminBeck can you update this PR to implement the feature in the PHP templates too ?

@BenjaminBeck

This comment has been minimized.

Copy link
Contributor Author

commented Oct 14, 2012

@stof yes, i´ll do it. Can you please tell me where i can find the PHP templates?

@stof

This comment has been minimized.

Copy link
Member

commented Oct 14, 2012

in FrameworkBundle

@fabpot

This comment has been minimized.

Copy link
Member

commented Dec 11, 2012

@BenjaminBeck Do you have time to finish this PR?

@BenjaminBeck

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2012

@fabpot Sorry, in the next 2-3 weeks i will have no time to finish it.

@stof

This comment has been minimized.

Copy link
Member

commented Dec 11, 2012

closed in favor of #6262

@stof stof closed this Dec 11, 2012

fabpot added a commit that referenced this pull request Dec 11, 2012

merged branch stloyd/feature/form-labels (PR #6262)
This PR was merged into the master branch.

Commits
-------

d5426f0 [Form] Add tests to prove that label is not rendered when is marked as false
120547c [Form][TwigBridge] Don't set label attributes if is marked as not to be rendered [Form][FrameworkBundle] Add option to disable rendering of label for fields
36e4556 [Form] Option for not displaying a label by setting label to false. [Form] Fixed formatting & translation ..

Discussion
----------

[Form] Added option for not displaying a form-label by setting label to false

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Replaces: #5421

@fabpot @BenjaminBeck: I was just not sure what to do with "table based" forms, so I left `<td></td>` rendered when there is no label, because I'm not sure that we can hide it easily.

---------------------------------------------------------------------------

by XWB at 2012-12-11T09:30:14Z

👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.