Added option for not displaying a form-label by setting label to false. #5421

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@BenjaminBeck
Contributor

BenjaminBeck commented Sep 3, 2012

....twig

Option for not displaying a label by setting label to false.

BenjaminBeck added some commits Sep 3, 2012

Update src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.h…
…tml.twig

Option for not displaying a label by setting label to false.
@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Sep 3, 2012

This pull request fails (merged 07a111e into 41ffd00).

This pull request fails (merged 07a111e into 41ffd00).

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Sep 3, 2012

Member

The same should be done for the PHP rendering

Member

stof commented Sep 3, 2012

The same should be done for the PHP rendering

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Sep 3, 2012

Member

and this is breaking a lots of tests

Member

stof commented Sep 3, 2012

and this is breaking a lots of tests

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Sep 3, 2012

This pull request passes (merged 9a06f29 into 41ffd00).

This pull request passes (merged 9a06f29 into 41ffd00).

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 13, 2012

Member

@BenjaminBeck can you update this PR to implement the feature in the PHP templates too ?

Member

stof commented Oct 13, 2012

@BenjaminBeck can you update this PR to implement the feature in the PHP templates too ?

@BenjaminBeck

This comment has been minimized.

Show comment
Hide comment
@BenjaminBeck

BenjaminBeck Oct 14, 2012

Contributor

@stof yes, i´ll do it. Can you please tell me where i can find the PHP templates?

Contributor

BenjaminBeck commented Oct 14, 2012

@stof yes, i´ll do it. Can you please tell me where i can find the PHP templates?

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 14, 2012

Member

in FrameworkBundle

Member

stof commented Oct 14, 2012

in FrameworkBundle

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 11, 2012

Member

@BenjaminBeck Do you have time to finish this PR?

Member

fabpot commented Dec 11, 2012

@BenjaminBeck Do you have time to finish this PR?

@BenjaminBeck

This comment has been minimized.

Show comment
Hide comment
@BenjaminBeck

BenjaminBeck Dec 11, 2012

Contributor

@fabpot Sorry, in the next 2-3 weeks i will have no time to finish it.

Contributor

BenjaminBeck commented Dec 11, 2012

@fabpot Sorry, in the next 2-3 weeks i will have no time to finish it.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Dec 11, 2012

Member

closed in favor of #6262

Member

stof commented Dec 11, 2012

closed in favor of #6262

@stof stof closed this Dec 11, 2012

fabpot added a commit that referenced this pull request Dec 11, 2012

merged branch stloyd/feature/form-labels (PR #6262)
This PR was merged into the master branch.

Commits
-------

d5426f0 [Form] Add tests to prove that label is not rendered when is marked as false
120547c [Form][TwigBridge] Don't set label attributes if is marked as not to be rendered [Form][FrameworkBundle] Add option to disable rendering of label for fields
36e4556 [Form] Option for not displaying a label by setting label to false. [Form] Fixed formatting & translation ..

Discussion
----------

[Form] Added option for not displaying a form-label by setting label to false

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Replaces: #5421

@fabpot @BenjaminBeck: I was just not sure what to do with "table based" forms, so I left `<td></td>` rendered when there is no label, because I'm not sure that we can hide it easily.

---------------------------------------------------------------------------

by XWB at 2012-12-11T09:30:14Z

👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment