New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing use statment #5825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed for-loop variables to match the current `form_div_layout.html.twig` code.
This PR was merged into the 2.1 branch. Commits ------- 3e15d44 Documented removed _form_is_choice_group function Discussion ---------- Documented removed `_form_is_choice_group` function Also changed for-loop variables to match the current `form_div_layout.html.twig` code.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #5746). Commits ------- 96d87ad [Locale] fixed fallback locale Discussion ---------- [Locale] fixed fallback locale The `getFallbackLocale()` method in `Symfony\Component\Locale\Locale` did not return a fallback locale if the current locale (`Locale::getDefault()`) was a 5-char locale like de_CH. `LocaleTest` failed when the locale was set to de_CH before running (see changes in LocaleTest). (second attempt after messing up PR#5641) --------------------------------------------------------------------------- by eriksencosta at 2012-10-15T05:08:25Z Original PR: #5641.
This PR was squashed before being merged into the 2.1 branch (closes #5789). Commits ------- 788cc2c Nsdocblocks Discussion ---------- Nsdocblocks Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: -
This PR was merged into the 2.1 branch. Commits ------- 039bdfd [WebProfilerBundle] Fixed the use of nested macros Discussion ---------- [WebProfilerBundle] Fixed the use of nested macros Closes #5800 --------------------------------------------------------------------------- by stof at 2012-10-22T20:03:10Z @fabpot ping. this regression is quite annoying as I like the profiler
added missing use statment
As far as I can see, that |
@return EntityManager is not valid class name because it doesn't exists in current namespace we should use full class name(FQCN) or "use" statment even it's used inside comment |
fabpot
added a commit
that referenced
this pull request
Oct 24, 2012
* 2.1: added missing use statment (closes #5825) Code cleanup [WebProfilerBundle] Fixed the use of nested macros Removed unused use statements. Nsdocblocks [ConfigDumpReference] avoid notice for variable nodes fixed fallback locale UniqueValidatorTest, Change message on assertions Documented removed _form_is_choice_group function Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/WebProfilerBundle/Profiler/TemplateManager.php
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.1: added missing use statment (closes symfony#5825) Code cleanup [WebProfilerBundle] Fixed the use of nested macros Removed unused use statements. Nsdocblocks [ConfigDumpReference] avoid notice for variable nodes fixed fallback locale UniqueValidatorTest, Change message on assertions Documented removed _form_is_choice_group function Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/WebProfilerBundle/Profiler/TemplateManager.php
sandergo90
pushed a commit
to sandergo90/symfony
that referenced
this pull request
Jul 4, 2019
* 2.1: added missing use statment (closes symfony#5825) Code cleanup [WebProfilerBundle] Fixed the use of nested macros Removed unused use statements. Nsdocblocks [ConfigDumpReference] avoid notice for variable nodes fixed fallback locale UniqueValidatorTest, Change message on assertions Documented removed _form_is_choice_group function Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/WebProfilerBundle/Profiler/TemplateManager.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes