Public resources refactoring #6000

Merged
merged 4 commits into from Nov 13, 2012

Projects

None yet

2 participants

@fabpot
Member
fabpot commented Nov 13, 2012

The first 3 commits are just cosmetic ones.

The last one refactors CSS, images, and templates included in the built-in bundles. Right now, everything is tied to the exception pages, but the code can be used standalone.

So, the goal is to make things more decoupled and more reusable across different bundles. That way, a bundle can provide pages that look like the other ones in Symfony without the need to duplicate code.

See the associated PR for the distribution bundle to see an example.

If you want to have a look at the last commit (not sure if it is worth it), you probably want to append ?w=1 to the URL to avoid too much whitespace noise.

fabpot added some commits Nov 12, 2012
@fabpot fabpot renamed sf-exceptionreset to sf-reset e0aab40
@fabpot fabpot uniformized styles 983b2b5
@fabpot fabpot replace _ in stylesheets (ids and classes) by - (should be consistent…
… across the whole framework now)
812b9b1
@fabpot fabpot refactored CSS, images, templates included in the built-in bundles
The goal is to make things more decoupled and more reusable across
different bundles.

There will be a PR for the distribution bundle too to simplify the code
based on this PR.
0159358
@fabpot fabpot referenced this pull request in sensiolabs/SensioDistributionBundle Nov 13, 2012
Merged

refactored assets based on the recent changes in Symfony #66

@pborreli
Contributor

congrats ! #6000

@fabpot
Member
fabpot commented Nov 13, 2012

A simple usage example:

{% extends "TwigBundle::layout.html.twig" %}

{% block body %}
    <div class="block">
        FOOBAR
    </div>
{% endblock %}
@fabpot fabpot added a commit that referenced this pull request Nov 13, 2012
@fabpot fabpot merged branch fabpot/public-resources (PR #6000)
This PR was merged into the master branch.

Commits
-------

0159358 refactored CSS, images, templates included in the built-in bundles
812b9b1 replace _ in stylesheets (ids and classes) by - (should be consistent across the whole framework now)
983b2b5 uniformized styles
e0aab40 renamed sf-exceptionreset to sf-reset

Discussion
----------

Public resources refactoring

The first 3 commits are just cosmetic ones.

The last one refactors CSS, images, and templates included in the built-in bundles. Right now, everything is tied to the exception pages, but the code can be used standalone.

So, the goal is to make things more decoupled and more reusable across different bundles. That way, a bundle can provide pages that look like the other ones in Symfony without the need to duplicate code.

See the associated PR for the distribution bundle to see an example.

If you want to have a look at the last commit (not sure if it is worth it), you probably want to append ?w=1 to the URL to avoid too much whitespace noise.

---------------------------------------------------------------------------

by pborreli at 2012-11-13T09:38:00Z

congrats ! #6000

---------------------------------------------------------------------------

by fabpot at 2012-11-13T09:38:39Z

A simple usage example:

```jinja
{% extends "TwigBundle::layout.html.twig" %}

{% block body %}
    <div class="block">
        FOOBAR
    </div>
{% endblock %}
```
83de4c2
@fabpot fabpot merged commit 0159358 into symfony:master Nov 13, 2012

1 check failed

default The Travis build failed
Details
@fabpot fabpot added a commit to sensiolabs/SensioDistributionBundle that referenced this pull request Nov 13, 2012
@fabpot fabpot merged branch sensio/assets-refactor (PR #66)
This PR was merged into the master branch.

Commits
-------

f656890 refactored assets based on the recent changes in Symfony

Discussion
----------

refactored assets based on the recent changes in Symfony

see symfony/symfony#6000
12a02ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment