Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[travis-ci] Zend Garbage Collection only for PHP5.4 #6063

Closed
wants to merge 2 commits into from

3 participants

@pborreli

No description provided.

@fabpot fabpot commented on the diff
autoload.php.dist
@@ -1,5 +1,10 @@
<?php
+if (version_compare(PHP_VERSION, '5.4', '>=') && gc_enabled()) {
+ // Disabling Zend Garbage Collection to prevent segfaults with PHP5.4+
@fabpot Owner
fabpot added a note

Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.

@fabpot Owner
fabpot added a note

Also, I'm not sure this is the right thing to do as for instance I have no problem running the test locally with PHP 5.4. Is it related to Travis somehow?

@stof Collaborator
stof added a note

@fabpot but is gc enabled locally ?

@fabpot had the same problem on multiple ubuntu vps already

@fabpot Owner
fabpot added a note

fair enough. Can you add the references to the PHP bugs before I merge?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@fabpot fabpot referenced this pull request from a commit
@fabpot fabpot merged branch pborreli/gc_memory (PR #6063)
This PR was squashed before being merged into the master branch (closes #6063).

Commits
-------

d3d8ff4 [travis-ci] Zend Garbage Collection only for PHP5.4

Discussion
----------

[travis-ci] Zend Garbage Collection only for PHP5.4
382d580
@fabpot fabpot closed this pull request from a commit
@fabpot fabpot merged branch pborreli/gc_memory (PR #6063)
This PR was squashed before being merged into the master branch (closes #6063).

Commits
-------

d3d8ff4 [travis-ci] Zend Garbage Collection only for PHP5.4

Discussion
----------

[travis-ci] Zend Garbage Collection only for PHP5.4
382d580
@fabpot fabpot closed this in 382d580
@stof
Collaborator

I think this should have been merged into 2.0 to avoid travis failures in the tetssuite for these branches

@mmucklo mmucklo referenced this pull request from a commit
@fabpot fabpot merged branch pborreli/gc_memory (PR #6063)
This PR was squashed before being merged into the master branch (closes #6063).

Commits
-------

d3d8ff4 [travis-ci] Zend Garbage Collection only for PHP5.4

Discussion
----------

[travis-ci] Zend Garbage Collection only for PHP5.4
d8f36a4
@pborreli pborreli deleted the unknown repository branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 2 deletions.
  1. +0 −2  .travis.yml
  2. +6 −0 autoload.php.dist
  3. +1 −0  phpunit.xml.dist
View
2  .travis.yml
@@ -9,5 +9,3 @@ before_script:
- COMPOSER_ROOT_VERSION=dev-master composer --prefer-source --dev install
- php src/Symfony/Component/Locale/Resources/data/build-data.php
- export USE_INTL_ICU_DATA_VERSION=1
-
-script: phpunit -dzend.enable_gc=0
View
6 autoload.php.dist
@@ -1,5 +1,11 @@
<?php
+if (version_compare(PHP_VERSION, '5.4', '>=') && gc_enabled()) {
+ // Disabling Zend Garbage Collection to prevent segfaults with PHP5.4+
@fabpot Owner
fabpot added a note

Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.

@fabpot Owner
fabpot added a note

Also, I'm not sure this is the right thing to do as for instance I have no problem running the test locally with PHP 5.4. Is it related to Travis somehow?

@stof Collaborator
stof added a note

@fabpot but is gc enabled locally ?

@fabpot had the same problem on multiple ubuntu vps already

@fabpot Owner
fabpot added a note

fair enough. Can you add the references to the PHP bugs before I merge?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ // https://bugs.php.net/bug.php?id=53976
+ gc_disable();
+}
+
$loader = require_once __DIR__.'/vendor/autoload.php';
use Doctrine\Common\Annotations\AnnotationRegistry;
View
1  phpunit.xml.dist
@@ -14,6 +14,7 @@
<php>
<ini name="intl.default_locale" value="en"/>
<ini name="intl.error_level" value="0"/>
+ <ini name="memory_limit" value="-1"/>
</php>
<testsuites>
Something went wrong with that request. Please try again.