Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[travis-ci] Zend Garbage Collection only for PHP5.4 #6063

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

pborreli commented Nov 19, 2012

No description provided.

@fabpot fabpot commented on the diff Nov 19, 2012

autoload.php.dist
@@ -1,5 +1,10 @@
<?php
+if (version_compare(PHP_VERSION, '5.4', '>=') && gc_enabled()) {
+ // Disabling Zend Garbage Collection to prevent segfaults with PHP5.4+
@fabpot

fabpot Nov 19, 2012

Owner

Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.

@fabpot

fabpot Nov 19, 2012

Owner

Also, I'm not sure this is the right thing to do as for instance I have no problem running the test locally with PHP 5.4. Is it related to Travis somehow?

@stof

stof Nov 19, 2012

Member

@fabpot but is gc enabled locally ?

@pborreli

pborreli Nov 19, 2012

Contributor

@fabpot had the same problem on multiple ubuntu vps already

@fabpot

fabpot Nov 19, 2012

Owner

fair enough. Can you add the references to the PHP bugs before I merge?

@pborreli

pborreli Nov 19, 2012

Contributor

done

@fabpot fabpot closed this in 382d580 Nov 19, 2012

Member

stof commented Nov 19, 2012

I think this should have been merged into 2.0 to avoid travis failures in the tetssuite for these branches

@pborreli pborreli deleted the unknown repository branch Nov 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment