[2.1] Fixed travis icon #6186

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@hason
Contributor
hason commented Dec 4, 2012

No description provided.

Owner
fabpot commented Dec 5, 2012

Do we really need this icon? I don't see the point.

Contributor
hason commented Dec 5, 2012

I think that this icon is very useful. Currently tests pass only on master branch (https://travis-ci.org/symfony/symfony/builds) so I prefer doctrine style:

Owner
fabpot commented Dec 5, 2012

Who is looking at this icon anyway? And we have lots of problems with Travis. So, even if it is red, it does not mean that the tests do not pass. So, I'm for removing this line from the README.

@fabpot fabpot closed this in c68dd37 Dec 10, 2012
@fabpot fabpot added a commit that referenced this pull request Dec 11, 2012
@fabpot fabpot Merge branch '2.0' into 2.1
* 2.0:
  fixed CS
  removed the Travis icon (as this is not stable enough -- many false positive, closes #6186)
  [Config] Loader::import must return imported data
  [HttpFoundation] fixed a small regression

Conflicts:
	README.md
	src/Symfony/Bridge/Twig/Extension/FormExtension.php
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/attributes.html.php
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/form_widget.html.php
	src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php
	src/Symfony/Component/Form/Form.php
	src/Symfony/Component/HttpFoundation/Request.php
	src/Symfony/Component/HttpFoundation/SessionStorage/PdoSessionStorage.php
	tests/Symfony/Tests/Bridge/Doctrine/Logger/DbalLoggerTest.php
d2885ad
@fabpot fabpot added a commit that referenced this pull request Dec 11, 2012
@fabpot fabpot Merge branch '2.1'
* 2.1:
  fixed CS
  fixed CS
  [Security] fixed path info encoding (closes #6040, closes #5695)
  [HttpFoundation] added some tests for the previous merge and removed dead code (closes #6037)
  Improved Cache-Control header when no-cache is sent
  removed unneeded comment
  Fix to allow null values in labels array
  fix date in changelog
  removed the Travis icon (as this is not stable enough -- many false positive, closes #6186)
  Revert "merged branch gajdaw/finder_splfileinfo_fpassthu (PR #4751)" (closes #6224)
  Fixed a typo
  Fixed: HeaderBag::parseCacheControl() not parsing quoted zero correctly
  [Form] Fix const inside an anonymous function
  [Config] Loader::import must return imported data
  [DoctrineBridge] Fixed caching in DoctrineType when "choices" or "preferred_choices" is passed
  [Form] Fixed the default value of "format" in DateType to DateType::DEFAULT_FORMAT if "widget" is not "single_text"
  [HttpFoundation] fixed a small regression

Conflicts:
	src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php
3c010db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment