[DependencyInjection] Throw when using $this or its internal scope from PHP config files
#62646
+5
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Dec 4, 2025
src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
di-loader-throw
branch
2 times, most recently
from
1a5091e to
bf44156
Compare
stof
approved these changes
Dec 4, 2025
…from PHP config files; use the `$loader` variable instead
nicolas-grekas
force-pushed
the
di-loader-throw
branch
from
bf44156 to
7ffcd64
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2025
…kas) This PR was merged into the 6.4 branch. Discussion ---------- [SecurityBundle] Fix tests with Symfony 7.4 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Needed after #62646 Commits ------- 6d8c5ed [SecurityBundle] Fix tests with Symfony 7.4
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BC layer brought by #61860 doesn't work: as described in #62547, the first call to load() has side effects which can break when the second and fallback call is made.
I don't see any other way. Well, one would be to operate on a clone, and if that works, rerun with the real container builder. But the overhead is going to be high for everybody.
I'm therefor proposing to change this as a BC BREAK. While less than ideal, this happens at compile time, and the fix is trivial and explained in the error message.