[TwigBundle] There is no CSS visibility of display, should be visible instead #6612

Merged
merged 1 commit into from Jan 8, 2013

Conversation

Projects
None yet
3 participants
Contributor

igorw commented Jan 8, 2013

No description provided.

@fabpot fabpot added a commit that referenced this pull request Jan 8, 2013

@fabpot fabpot merged branch igorw/visibility-display (PR #6612)
This PR was merged into the 2.0 branch.

Commits
-------

8da2b41 [TwigBundle] There is no CSS visibility of display, should be visible instead

Discussion
----------

[TwigBundle] There is no CSS visibility of display, should be visible instead
0544805

@fabpot fabpot merged commit 8da2b41 into symfony:2.0 Jan 8, 2013

1 check passed

default The Travis build passed
Details
Contributor

vicb commented Jan 8, 2013

@igorw using the CSS display property - instead of visibility - would allow removing this ugly margin . It has been done in https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig#L97

igorw deleted the igorw:visibility-display branch Jan 8, 2013

Contributor

igorw commented Jan 8, 2013

Yeah. But since it's already fixed in master, I'd rather just leave it.

Contributor

vicb commented Jan 8, 2013

I'm not sure to get what you mean ?

Contributor

igorw commented Jan 8, 2013

Let me rephrase: Does it make sense to backport such things to 2.0?

Contributor

vicb commented Jan 8, 2013

We can not talk of a backport as it is not fixed in master (the link above is not related to the same file). But it should be changed in master only (not a bug fix), if needed.

Contributor

igorw commented Jan 8, 2013

Ok. In that case, I'll look into making it consistent for 2.3.

Contributor

vicb commented Jan 8, 2013

Thanks, should I create an issue to make sure it doesn't get lost ?

Contributor

igorw commented Jan 8, 2013

@vicb I just created the PR ^.

@fabpot fabpot added a commit that referenced this pull request Mar 23, 2013

@fabpot fabpot merged branch igorw/css-display (PR #6624)
This PR was merged into the master branch.

Discussion
----------

[2.3][TwigBundle] Use display instead of visibility for exception page icons

Originally spawned from #6612, this allows us to get rid of the ugly margins for the open and close icons on the exception page.

Commits
-------

e66bd14 [TwigBundle] Use display instead of visibility for exception page icons
5b5c7db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment