[FrameworkBundle] fixed requirement of the _controller placeholder for the proxy route (closes #6783)

[fabpot]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#6783
License	MIT
Doc PR	n/a

[vicb]

What about a UT ?

[Tobion]

I don't think this fixes #6783 because AFAIK it would match _controller = foo; _format = bar.service:blah.format

[Tobion]

So either format matches eagerly then controller could not include a dot. Or controller matches eagerly, then format could not contain a dot.

[vicb]

and the syntax is wrong also !

[gimler]

same problem the sonata admin bundle use

{% render 'sonata.admin.controller.admin:getShortObjectDescriptionAction' %}

rewrite to

{% render controller('sonata.admin.controller.admin:getShortObjectDescriptionAction') %}

throws

An exception has been thrown during the rendering of a template ("Parameter "_controller" for route "_proxy" must match "[^/\.]++" ("sonata.admin.controller.admin:getShortObjectDescriptionAction" given) to generate a corresponding URL.") in "SonataAdminBundle:CRUD:edit.html.twig". 

with the requirement fix it throws

An exception has been thrown during the rendering of a template ("Unable to parse the controller name "sonata".") in "SonataAdminBundle:CRUD:edit.html.twig". 

[fabpot]

ok, I've updated the patch. There is now a static segment (/for) between the controller and the format, which should fix the problem.

While thinking about this, there is another option, which might be even better: removing the need for the proxy route altogether and check for a defined path like /_proxy. It would remove the dependency on a Url Generator in the rendering strategy, and would not make the router proxy listener any more complex.

[gimler]

+1 for me the patch works i will open a PR for sonata doctrine orm bundle

{% render controller('sonata.admin.controller.admin:getShortObjectDescriptionAction', {},  {
    'code':     sonata_admin.field_description.associationadmin.code,
    'objectId': sonata_admin.field_description.associationadmin.id(sonata_admin.value),
    'uniqid':   sonata_admin.field_description.associationadmin.uniqid
})

[gimler]

When the proxy route is nessesary we should add a note into the upgrade guide.

+1 for less complexesy

[fabpot]

There is one issue with removing the proxy route: when generating a proxy URL, we need a Request instance, which is not always the case. I'm going to submit another PR to "fix" that first.

[vicb]

It would remove the dependency

Paul leaves this body :)

[Tobion]

IMO this would be nicer: /_proxy/{_controller}/{_format}

[Tobion]

I don't think removing the proxy route is good. That's the purpose of the routing system to handle generating and matching. Now if you do it manually it will probably show a bad approach to people to handle such stuff.
Also people cannot see what routes are defined explicitly and use tools like router:debug.

[fabpot]

@Tobion: see #6829

[fabpot]

I've again changed the route pattern to avoid any possible problems (even if a controller contains a /).

[Tobion]

Can a controller contain /? It's neither a valid service nor a valid class name or?

[mvrhov]

AFAIK yes, at least I used Namespace/SubController more then once...

[stof]

@mvrhov the namespace separator in PHP is \, not /

[vicb]

@stof $controller = str_replace('/', '\\', $controller);

[soerenmartius]

hey.. i am on symfony 2.2 beta1. When I try to render a controller from a template i got the exception:

An exception has been thrown during the rendering of a template ("No route found for "GET /_proxy"") in AnchorbrandsMessageBundle:Message:Show/show.html.twig at line 19.

It worked before the proxy.xml was removed

[stof]

@caramba13337 in 2.2-beta1, the controller syntax was not working at all. The PR has been merged after that for beta2

[soerenmartius]

@stof i ve set symfony requirement to 2.2* in my composer.json so what is the correct one to get the fixed vendors?

[csanquer]

I have the same exception with propel bundle and symfony 2.2 beta 2 :

An exception has been thrown during the rendering of a template ("No route found for "GET /_proxy"") in PropelBundle:Collector:propel.html.twig at line 110

[soerenmartius]

Charles: put router_proxy: { path: /_proxy } to the framework section
in your config.yml. correct syntax is described here:
http://symfony.com/doc/current/book/templating.html#embedding-controllers

2013/1/24 Charles SANQUER notifications@github.com

I have the same exception with propel bundle and symfony 2.2 beta 2 :

An exception has been thrown during the rendering of a template ("No route found for "GET /_proxy"") in PropelBundle:Collector:propel.html.twig at line 110

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6791#issuecomment-12648618.

[csanquer]

Thx @caramba1337.

Nice to see the master branch documentation has been updated.

[chrisnoden]

I'm new to Symfony. I have 2.2.1 and when using the DB profiler (with Propel) I get the error: An exception has been thrown during the rendering of a template ("No route found for "GET Panel:configuration"") in PropelBundle:Collector:propel.html.twig at line 107.
500 Internal Server Error - Twig_Error_Runtime
2 linked Exceptions: NotFoundHttpException » ResourceNotFoundException »

So I added to my config.yml, framework section:
router_proxy: { path: /_proxy }

Now I get:
InvalidConfigurationException: Unrecognized options "router_proxy" under "framework"

[stof]

@chrisnoden it is fragments, not router_proxy

[chrisnoden]

Old -> fragments: ~
New -> fragments: { path: /_proxy }

Either way, it doesn't fix the propel db profiler. I still get the Twig_Error_Runtime and the previously mentioned message.

[stof]

@chrisnoden are you using the latest PropelBundle ?