Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[2.3] [FrameworkBundle] added route debug information when path matches url #6950

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

inmarelibero commented Feb 2, 2013

the result of the command app/console router:match /demo/hello/foo would be:

Schermata 02-2456326 alle 17 04 42

instead of just:

Route "_demo_hello" matches
Owner

fabpot commented Feb 4, 2013

I don't see why you would want that as the route matches. I might understand adding that to the other cases, when there is a problem, but then, why nor use the router:debug command?

Contributor

inmarelibero commented Feb 4, 2013

because when url does not match any route, no route is found and it's not possible to run router:debug on a non-existent route.
but if the given url matches a route (eg '_demo_hello') and I want more info about the pattern, it is displayed subsequently instead of executing another command in the console. it seems a useful information to me when matching a route

Contributor

lsmith77 commented Feb 7, 2013

well i think its a common enough use case, that supporting it would make sense .. but i would limit it to enabling an optional parameter

Contributor

inmarelibero commented Feb 7, 2013

imho I find it sufficiently useful to be integrated as is, but if you say I can introduce an option to the command

@fabpot fabpot closed this in 3b1147e Mar 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment