Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[WIP] Removed deprecated stuff #7227

Merged
merged 14 commits into from Mar 23, 2013

Conversation

Projects
None yet
4 participants
Owner

fabpot commented Mar 1, 2013

No description provided.

@Tobion Tobion and 2 others commented on an outdated diff Mar 6, 2013

...ony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -216,7 +216,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
*/
public function getParent()
{
- return 'field';
+ return 'form';
@Tobion

Tobion Mar 6, 2013

Member

I think it would be easier to simply remove the whole method getParent because we can inherit the default from AbstractType. Less code is usually better.

@stof

stof Mar 6, 2013

Member

agreed

@wouterj wouterj referenced this pull request in symfony/symfony-docs Mar 11, 2013

Closed

[2.3] Removed deprecated stuff #2298

Member

wouterj commented Mar 11, 2013

I created a documentation issue about removing all these things in the documentation as well. I think we should not merge this PR before the documentation is up to date, conform our merging progress.

@stof stof referenced this pull request Mar 19, 2013

Closed

Update services.xml #7420

@fabpot fabpot added a commit that referenced this pull request Mar 23, 2013

@fabpot fabpot merged branch fabpot/deprecated (PR #7227)
This PR was merged into the master branch.

Discussion
----------

[WIP] Removed deprecated stuff

Commits
-------

f2a8908 removed deprecated functionality from RouteCollection
4f4a5d1 [TwigBundle] removed deprecated syntax
45bd413 [FrameworkBundle] removed deprecated options
0bb5d01 [FrameworkBundle] removed deprecated cookie options
b3081e8 [Form] removed deprecated methods and classes
e0385a2 [Validator] removed deprecated methods
65e3b16 [Validator] removed deprecated constraints
4a70ddf [HttpFoundation] removed deprecated session methods
4e7943f [Yaml] removed deprecated support of PHP parsin when parsing YAML files
09a5969 [HttpFoundation] removed deprecated Request::splitHttpAcceptHeader() method
c28f1b0 removed deprected way to declared trusted proxies
5ff6006 removed deprecated stuff in the fragment sub-framework
0a06a7c [Translation] removed deprecated classes
67f6397 [Security] removed deprecated classes
2675007

@fabpot fabpot closed this Mar 23, 2013

@fabpot fabpot merged commit f2a8908 into symfony:master Mar 23, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment