[Validator] Code property can't be populated to ConstraintViolation #7276

aeoris · 2013-03-05T22:54:26Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#7273, #9691
License	MIT
Doc PR	symfony/symfony-docs#2302

vicb · 2013-03-06T15:19:08Z

src/Symfony/Component/Validator/Constraints/BlankValidator.php

@@ -27,7 +27,7 @@ class BlankValidator extends ConstraintValidator
    public function validate($value, Constraint $constraint)
    {
        if ('' !== $value && null !== $value) {
-            $this->context->addViolation($constraint->message, array('{{ value }}' => $value));
+            $this->context->addViolation($constraint->message, array('{{ value }}' => $value), null, null, $constraint->code);


Take a look at context->addViolation(), I think passing null as the 3rd argument is not equivalent to what was done before, there's a gotcha in the method !

Oh! You mean passing $value instead? If so, please tell me and I will change all of them to consider that! Did you detect any other issues?

Yep this is what I mean (and you should add a unit test for that)

No other issue detected but I only quickly scanned it.

aeoris · 2013-03-12T23:26:36Z

Ping @vicb

Did my last couple commits solve the issue you pointed out?

vicb · 2013-03-13T06:25:33Z

Looks good.
Please use the standard pr header (found on symfony.com). Thanks.

"Diego Agulló" notifications@github.com wrote:

Ping @vicb

Did my last couple commits solve the issue you pointed out?

Reply to this email directly or view it on GitHub:
#7276 (comment)

aeoris · 2013-03-13T09:33:26Z

Done! I just don't know whether this is a new feature or a bug fix, so I selected both and made a PR to symfony-docs as well.

stof · 2013-03-19T23:47:08Z

you are adding a way to configure the code in the constraint. This is a new feature. I updated the description accordingly

fabpot · 2013-09-13T10:19:14Z

ping @bschussek

webmozart · 2013-09-16T18:46:24Z

@fabpot The implementation of this PR doesn't match the specification in #7273.

@aeoris Do you have time to update this PR?

aeoris · 2013-11-02T17:33:52Z

@bschussek Haven't forgot this issue, and I'm happy to say that I finally have time enough to give it a go. I'm on it!

…onCode Conflicts: src/Symfony/Component/Validator/Constraints/CountryValidator.php src/Symfony/Component/Validator/Constraints/LanguageValidator.php src/Symfony/Component/Validator/Constraints/LocaleValidator.php src/Symfony/Component/Validator/Constraints/MaxLengthValidator.php src/Symfony/Component/Validator/Constraints/MaxValidator.php src/Symfony/Component/Validator/Constraints/MinLengthValidator.php src/Symfony/Component/Validator/Constraints/MinValidator.php

aeoris · 2013-11-08T07:32:34Z

@bschussek can you please check whether this PR matches #7273 now? Thanks!

cordoval · 2013-12-06T14:04:07Z

@aeoris could you please add to the description table that it fixes #9691 please ? 👶

aeoris · 2013-12-06T16:51:38Z

@cordoval done, thanks!

cordoval · 2013-12-21T17:53:18Z

👍 just make sure you have not missed testing each of those codes i guess? also how are you generating the codes, so that in future additions is clear how you are generating those codes. Thanks.

aeoris · 2013-12-23T11:24:58Z

@cordoval I'll double check the tests as soon as I get back home next Monday.

The codes are RFC 4122-compliant 128 bit random values as proposed here by @bschussek: #7273 (comment)

aeoris · 2014-02-15T18:47:44Z

@cordoval I did indeed miss three code checks, but those are fixed now.

stloyd · 2014-03-11T12:13:42Z

@fabpot @webmozart Could you have a look at this?

aeoris · 2014-05-23T08:02:10Z

@webmozart any progress on this?

… (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added ConstraintViolation::getConstraint() | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5050 | License | MIT | Doc PR | - This PR adds a `getConstraint()` method to the `ConstraintViolation` in order to access the constraint causing the violation. Related to #7276, #7273 and #9691. Commits ------- ce1d209 [Validator] Added ConstraintViolation::getConstraint()

webmozart · 2014-09-23T15:34:21Z

Replaced by #12005.

This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Simplified testing of violations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I simplified the assertion of violations in preparation of a replacement PR for #7276. Commits ------- 8e5537b [Validator] Simplified testing of violations

…multiple error causes (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added error codes to all constraints with multiple error causes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7276 | License | MIT | Doc PR | TODO This PR depends on #12015 and #12016 being merged first. However, a few changes in 52cb7df first must be backported to #12016. This PR introduces error codes for all constraints with multiple error paths. This lets you determine what exactly the reason was that a constraint failed: ```php $validator = Validation::createValidator(); $violations = $validator->validate('0-4X19-92619812', new Isbn()); foreach ($violations as $violation) { var_dump($violation->getCode()); // => int(3) var_dump(Isbn::getErrorName($violation->getCode())); // => string(24) "ERROR_INVALID_CHARACTERS" var_dump($violation->getConstraint()->getErrorName($violation->getCode())); // => string(24) "ERROR_INVALID_CHARACTERS" } ``` The `getErrorName()` method is especially helpful for REST APIs, where you can return both an error code and a description of that error now. **Todos** - [x] Backport a few structural changes to #12016 - [x] Update constraints outside of the Validator component - [x] Rebase on master (after merging #12015 and #12016) Commits ------- 3b50bf2 [Validator] Added error codes to all constraints with multiple error causes

Updated validators and added $code to Constraint class (#7273)

07b4bd5

vicb reviewed Mar 6, 2013
View reviewed changes

aeoris added 2 commits March 6, 2013 21:20

Pass the invalid value to addViolation and added some tests

28ff374

camelCased function name on test

31ac981

aeoris mentioned this pull request Mar 13, 2013

[WCM] Add information on code property population symfony/symfony-docs#2302

Closed

aeoris added 2 commits November 2, 2013 19:15

Added unique error codes on constraints (#7273, #7276, #5525).

82249ff

aeoris mentioned this pull request Dec 6, 2013

[Validator] Missing metadata in ConstraintViolation result #9691

Closed

aeoris added 2 commits February 15, 2014 19:41

Fixed validator tests whose code check was missing.

a6a2e0f

CS fixes.

4ee7a84

aeoris mentioned this pull request Mar 11, 2014

[Validator] Add error code to constraints #10413

Closed

webmozart mentioned this pull request Aug 12, 2014

[Validator] Added ConstraintViolation::getConstraint() #11657

Merged

webmozart closed this Sep 23, 2014

aeoris mentioned this pull request Sep 23, 2014

[Validator] Added "payload" option to all constraints for attaching domain-specific data #12005

Merged

This was referenced Sep 24, 2014

[Validator] Simplified testing of violations #12015

Merged

[Validator] Added error codes to all constraints with multiple error causes #12021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validator] Code property can't be populated to ConstraintViolation #7276

[Validator] Code property can't be populated to ConstraintViolation #7276

aeoris commented Mar 5, 2013

vicb Mar 6, 2013

aeoris Mar 6, 2013

vicb Mar 6, 2013

aeoris commented Mar 12, 2013

vicb commented Mar 13, 2013

aeoris commented Mar 13, 2013

stof commented Mar 19, 2013

fabpot commented Sep 13, 2013

webmozart commented Sep 16, 2013

aeoris commented Nov 2, 2013

aeoris commented Nov 8, 2013

cordoval commented Dec 6, 2013

aeoris commented Dec 6, 2013

cordoval commented Dec 21, 2013

aeoris commented Dec 23, 2013

aeoris commented Feb 15, 2014

stloyd commented Mar 11, 2014

aeoris commented May 23, 2014

webmozart commented Sep 23, 2014

[Validator] Code property can't be populated to ConstraintViolation #7276

[Validator] Code property can't be populated to ConstraintViolation #7276

Conversation

aeoris commented Mar 5, 2013

vicb Mar 6, 2013

Choose a reason for hiding this comment

aeoris Mar 6, 2013

Choose a reason for hiding this comment

vicb Mar 6, 2013

Choose a reason for hiding this comment

aeoris commented Mar 12, 2013

vicb commented Mar 13, 2013

aeoris commented Mar 13, 2013

stof commented Mar 19, 2013

fabpot commented Sep 13, 2013

webmozart commented Sep 16, 2013

aeoris commented Nov 2, 2013

aeoris commented Nov 8, 2013

cordoval commented Dec 6, 2013

aeoris commented Dec 6, 2013

cordoval commented Dec 21, 2013

aeoris commented Dec 23, 2013

aeoris commented Feb 15, 2014

stloyd commented Mar 11, 2014

aeoris commented May 23, 2014

webmozart commented Sep 23, 2014