Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[2.2][Console] Fix autocompletion of command names when namespaces conflict #7589

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Member

Seldaek commented Apr 7, 2013

Fixes #7234

Currently autocompletion of namespaces works on all namespaces at once. This fixes it to only search inside subnamespaces once we matched the first level namespace. Otherwise if you have api:doc and generate:doctrine:entity commands, typing gen:doc:entity trips it up because it thinks "doc" is "api:doc", and you end up with a completed name of generate:doc:entity which does not match any command.

fabpot added a commit that referenced this pull request Apr 7, 2013

merged branch Seldaek/autocomplete_fix (PR #7589)
This PR was submitted for the 2.2 branch but it was merged into the 2.1 branch instead (closes #7589).

Discussion
----------

[2.2][Console] Fix autocompletion of command names when namespaces conflict

Fixes #7234

Currently autocompletion of namespaces works on *all* namespaces at once. This fixes it to only search inside subnamespaces once we matched the first level namespace. Otherwise if you have `api:doc` and `generate:doctrine:entity` commands, typing `gen:doc:entity` trips it up because it thinks "doc" is "api:doc", and you end up with a completed name of `generate:doc:entity` which does not match any command.

Commits
-------

fa465b1 [2.2][Console] Fix autocompletion of command names when namespaces conflict

@fabpot fabpot closed this Apr 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment