Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Security] [Acl] [BasicPermissionMap] Made $map protected and moved it to __construct #7601

Merged
merged 1 commit into from Apr 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

Brammm commented Apr 8, 2013

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

By making $map protected and moving it to the construct, you can simply extend the BasicPermissionMap class if you want to simply add some extra permissions. In it's current form, you have to copy/paste the entire array AND the getMasks and contains functions. 

@Brammm Brammm Made $map protected and moved it to construct.
By making $map protected and moving it to the construct, you can simply extend the BasicPermissionMap class if you want to simply add some extra permissions. In it's current form, you have to copy/paste the entire array AND the getMasks and contains functions. 
1369d54

@fabpot fabpot added a commit that referenced this pull request Apr 9, 2013

@fabpot fabpot merged branch Brammm/master (PR #7601)
This PR was merged into the master branch.

Discussion
----------

[Security] [Acl] [BasicPermissionMap] Made $map protected and moved it to __construct

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

By making $map protected and moving it to the construct, you can simply extend the BasicPermissionMap class if you want to simply add some extra permissions. In it's current form, you have to copy/paste the entire array AND the getMasks and contains functions. 

Commits
-------

1369d54 Made $map protected and moved it to construct.
69c5794

@fabpot fabpot closed this Apr 9, 2013

@fabpot fabpot merged commit 1369d54 into symfony:master Apr 9, 2013

1 check passed

default Scrutinizer: No Comments — Travis: Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment