New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomCrawler] Fixes `attr` method returning empty string for missing attributes #9578

Closed
wants to merge 1 commit into
base: 2.3
from

Conversation

Projects
None yet
2 participants
@aik099
Contributor

aik099 commented Nov 22, 2013

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Bug discovered on Behat/MinkBrowserKitDriver#32.

@fabpot fabpot closed this in 57c695b Nov 23, 2013

@fabpot

This comment has been minimized.

Member

fabpot commented Nov 23, 2013

I've merged this PR into master instead as it breaks the current behavior and people might have relied on the current one. I've also added a note in the PHPDoc about this change. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment