Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Removed ini check to make Uploadedfile work on Google App Engine #9784

Closed

Conversation

Projects
None yet
4 participants
@micheleorselli
Copy link
Contributor

commented Dec 15, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

related to #9238

@fabpot

This comment has been minimized.

Copy link
Member

commented Dec 15, 2013

That change does not make any sense. We're not going to remove features or checks because of some platforms.

@micheleorselli

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2013

Thank you for the quick response, I'm closing the PR

@micheleorselli micheleorselli deleted the micheleorselli:uploaded_file_gae branch Dec 15, 2013

@cordoval

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2013

we have to do this in a thread providing support for read only filesystems

@ircmaxell

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2014

Requesting this be re-opened and reconsidered as per discussion in #9945

fabpot added a commit that referenced this pull request Mar 25, 2014

bug #9784 [HttpFoundation] Removed ini check to make Uploadedfile wor…
…k on Google App Engine (micheleorselli)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9784).

Discussion
----------

[HttpFoundation] Removed ini check to make Uploadedfile work on Google App Engine

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes

related to #9238

Commits
-------

ecb6481 removed ini check to make uploadedfile work on gae
@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 25, 2014

@ircmaxell This PR has been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.