New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrowserKit] Throw exception on invalid cookie expiration timestamp #9949

Closed
wants to merge 2 commits into
base: 2.3
from

Conversation

Projects
None yet
4 participants
@anlutro
Contributor

anlutro commented Jan 6, 2014

Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jan 6, 2014

Member

👍

Member

stof commented Jan 6, 2014

👍

1 similar comment
@piotrpasich

This comment has been minimized.

Show comment
Hide comment
@piotrpasich

piotrpasich commented Jan 6, 2014

👍

fabpot added a commit that referenced this pull request Jan 6, 2014

bug #9949 [BrowserKit] Throw exception on invalid cookie expiration t…
…imestamp (anlutro)

This PR was squashed before being merged into the 2.3 branch (closes #9949).

Discussion
----------

[BrowserKit] Throw exception on invalid cookie expiration timestamp

Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

8df535d [BrowserKit] Throw exception on invalid cookie expiration timestamp

@fabpot fabpot closed this Jan 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment