Skip to content

Prevent RCE when calling untrusted remote with CachingHttpClient

fabpot published GHSA-754h-5r27-7x3r Sep 2, 2020
Severity
moderate
Packages
symfony/http-kernel, symfony/symfony (composer)
Affected versions
>= 4.4.0, <4.4.13 || >= 5.1.0, <5.1.5
Patched versions
4.4.13, 5.1.5
CVE identifier
CVE-2020-15094

Description

The CachingHttpClient class from the HttpClient Symfony component relies on the HttpCache class to handle requests. HttpCache uses internal headers like X-Body-Eval and X-Body-File to control the restoration of cached responses. The class was initially written with surrogate caching and ESI support in mind (all HTTP calls come from a trusted backend in that scenario). But when used by CachingHttpClient and if an attacker can control the response for a request being made by the CachingHttpClient, remote code execution is possible.

Resolution

HTTP headers designed for internal use in HttpCache are now stripped from remote responses before being passed to HttpCache.

The patch for this issue is available here for the 4.4 branch.

Credits

I would like to thank Matthias Pigulla (webfactory GmbH) for reporting and fixing the issue.

Credits