This repository was archived by the owner on Nov 9, 2017. It is now read-only.
fixed customized schema name in gentle introduction #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIU, this is already merged. If so, can you close this pull request. |
|
It's not merged: it could look confusing, since git it's showing some other commits I already merged (since they are related only to Italian translation). The relevant commit is 176831a, that's related to all languages. |
|
You are right, this is indeed confusing. I have pushed your change. Thanks. |
hidenorigoto
pushed a commit
that referenced
this pull request
Nov 29, 2011
Review and update the content of translation of the Jobeet doc, chapter 1
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the schema name in chapter 17 is wrong: currently an underscore is used, but Propel override it only if using a dash. See the diffs.