-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for composer-plugin-api v2 #85
Conversation
Thanks for working on this :)
Is there really nothing we can do? What are the exact blockers? |
Thanks for the quick reply @nicolas-grekas :) Composer v2 has a |
@nicolas-grekas - I force-pushed a new update commit that supports both composer API versions. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some changes before merging.
Thank you @Ayesh. |
Tagged as v1.2.6 |
Composer version 2 has
composer-plugin-api
version 2, and this plugin attemts to support both API versions.See What's new in Composer 2 and UPGRADE-2.0 for more changes in API.
\Symfony\Thanks\Thanks::deactivate()
and\Symfony\Thanks\Thanks::uninstall()
are added to make it compatible both versions.\Hirak\Prestissimo\CurlRemoteFilesystem
is not used in favor of Composer's native\Composer\Util\HttpDownloader
which make multiple Curl connections.Related: #84 and composer/composer#8726.
thanks
🙏