Skip to content
Permalink
Branch: master
Commits on Jun 9, 2019
Commits on Jun 7, 2019
Commits on Jun 3, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Jun 3, 2019
    * 4.4:
      [Translation] Fixed case sensitivity of lint:xliff command
      fix type hint for salt in PasswordEncoderInterface
      Add missing deprecations for PHP templating layer
      Simplify code - catch \Throwable capture all exceptions
      Collect locale details earlier in the process in TranslationDataCollector
      fix typo in PR #31802
      update italian validator translation
      Add missing translations
      [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor
      [SecurityBundled] Forbid security-http >= 5.0
      [Security][Guard] Forbid security-http >= 5.0
      [TwigBridge] suggest Translation Component when TranslationExtension is used
      [Monolog] Setup the LoggerProcessor after all other processor
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jun 3, 2019
    * 4.3:
      [Translation] Fixed case sensitivity of lint:xliff command
      fix type hint for salt in PasswordEncoderInterface
      Simplify code - catch \Throwable capture all exceptions
      Collect locale details earlier in the process in TranslationDataCollector
      fix typo in PR #31802
      update italian validator translation
      Add missing translations
      [TwigBridge] suggest Translation Component when TranslationExtension is used
  3. Merge branch '4.2' into 4.3

    nicolas-grekas committed Jun 3, 2019
    * 4.2:
      [Translation] Fixed case sensitivity of lint:xliff command
      fix type hint for salt in PasswordEncoderInterface
      Simplify code - catch \Throwable capture all exceptions
      fix typo in PR #31802
      update italian validator translation
      Add missing translations
  4. bug #31815 [Translator] Collect locale details earlier in the process…

    nicolas-grekas committed Jun 3, 2019
    … (pierredup)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Translator] Collect locale details earlier in the process
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31600
    | License       | MIT
    | Doc PR        | N/A
    
    The [LocaleAwareListener](https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php) class reverts the locale back to the default locale when the request has finished. But the `TranslationDataCollector` only collects the locale in `lateCollect`, which only happens when the kernel terminates. This means the locale is reverted back to the default by the time the collector runs.
    
    The PR moves the `locale` and `fallback_locales` from `lateCollect` to `collect`, so that the information can be captured earlier, before the `LocaleAwareListener` is run.
    
    Commits
    -------
    
    5c394eeb79 Collect locale details earlier in the process in TranslationDataCollector
You can’t perform that action at this time.