[RFC] Don't enforce self type in equals method

[hhamon]

Thanks @lyrixx for the component,

I suggest not to enforce the typehint for the equals method to enable more flexibility.

This would allow one to do write code as is:

$uuid->equals($anObjectOfAnotherType); // false
$uuid->equals($anotherUuidObject); // true / false
$uuid->equals($aNullValue); // false
$uuid->equals('974d05ab-835e-4d58-af3d-88a0666c5e74'); // true / false

What do you think?

PS: I'll update unit tests if a consensus agrees on this change.

[nicolas-grekas]

I think accepting strings makes the method less useful as it forces another check to know the type.

I'm good with accepting other types and returning false.

[hhamon]

Sounds legit

[nicolas-grekas]

don't forget to add a test :)

[kunicmarko20]

Shouldn't this PR be on https://github.com/symfony/symfony?

[nicolas-grekas]

@kunicmarko20 totally!
@hhamon closing therefor.

[hhamon]

Oups indeed, I'am opening it on Symfony repository

[hhamon]

See symfony/symfony#36058