[Autocomplete] Reset TomSelect when updating controller attributes - #1505
Merged
Conversation
weaverryan
reviewed
Feb 15, 2024
pierredup
commented
Feb 16, 2024
|
I also need this fix. What is the status here? |
pierredup
force-pushed
the
autocomplete-remote-options
branch
from
November 20, 2024 13:31
55cc7a2 to
d14a526
Compare
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||
|
thank you to everyone that participated in the bug fix! |
Member
|
Hey @pierredup, i'm reviving this PR, hoping it's still something you'd like to merge! How "ready-to-merge" are these changes? Is there anything i need to check in particular? Thank you! |
Contributor
Author
|
Hi @smnandre , there's nothing outstanding on this from my side, so I think it's ready to be merged |
Member
|
@pierredup great, LGTM! Could you rebase and add an entry in the src/Autocomplete/CHANGELOG.md (2.23) ? |
pierredup
force-pushed
the
autocomplete-remote-options
branch
from
December 23, 2024 14:35
2fbae82 to
9ec287f
Compare
smnandre
force-pushed
the
autocomplete-remote-options
branch
from
December 23, 2024 14:55
9ec287f to
d8fb3fb
Compare
Member
|
Thanks for your patience! :) |
smnandre
added
Status: Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using remote data for Autocomplete, the mutation observer is not started, so the select cannot be reset when some options change (E.G when limiting the options returned after selecting other options using extra_options from #1322).
Instead, we start the mutation observer when using remote data. When the observer runs and checks if the options have changes, we explicitly set the
areOptionsEquivalenttotrue, since the page will just render an emptyselect. We also check if any of thedata-autocompleteattributes changes and forces a reset (E.G using extra_options, thedata-autocomplete-urlvalue can be different when using extra options, so we reset the select when this attribute changes).This fixes only one of the issues from #1500, I'll investigate the other issues and create separate PRs.