Skip to content

[Notify] Added options to Notification - #1853

Merged
Kocal merged 1 commit into
symfony:2.xfrom
ernie76:NotifierMercure
Apr 4, 2025
Merged

[Notify] Added options to Notification#1853
Kocal merged 1 commit into
symfony:2.xfrom
ernie76:NotifierMercure

Conversation

@ernie76

@ernie76 ernie76 commented May 17, 2024

Copy link
Copy Markdown
Q A
Bug fix? no
New feature? yes
License MIT

Added body, icon, tag ,renotify for desktop notifications
This pull-request are need changes in src/Symfony/Component/Notifier/Bridge/Mercure/MercureOptions.php. I have made a pull request there too.

@carsonbot carsonbot added Feature New Feature Status: Needs Review Needs to be reviewed labels May 17, 2024
@ernie76 ernie76 changed the title Notifier mercure [Notifier] mercure May 17, 2024
@ernie76 ernie76 changed the title [Notifier] mercure [Notifier] mercure add body, icon, tag ,renotify May 17, 2024
@ernie76

ernie76 commented May 17, 2024

Copy link
Copy Markdown
Author

this PR connected to this PR symfony/symfony#54961

topics: Array,
};

export { default_1 as default };

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a breaking change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have edit this

@ernie76 ernie76 changed the title [Notifier] mercure add body, icon, tag ,renotify [Notifier] mercure add options May 22, 2024
@kbond kbond added the Notify label May 22, 2024
@kbond kbond changed the title [Notifier] mercure add options [Notify] mercure add options May 22, 2024
@fabpot

fabpot commented Apr 4, 2025

Copy link
Copy Markdown
Member

PR on the Symfony side has been merged now.

Comment thread src/Notify/CHANGELOG.md Outdated

@ernie76 ernie76 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change Changelog

@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Notify
controller.d.ts 564 B / 320 B 604 B+7% 📈 / 338 B+6% 📈
controller.js 2.25 kB / 798 B 2.36 kB+5% 📈 / 824 B+3% 📈

@ernie76

ernie76 commented Apr 4, 2025

Copy link
Copy Markdown
Author

PR on the symfony side symfony/symfony#60140

Comment thread src/Notify/CHANGELOG.md Outdated
Comment thread src/Notify/CHANGELOG.md
Comment thread src/Notify/assets/src/controller.ts Outdated
@Kocal
Kocal force-pushed the NotifierMercure branch from accfc1c to b846ad5 Compare April 4, 2025 17:03
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 4, 2025
@Kocal Kocal changed the title [Notify] mercure add options [Notify] Added options to Notification Apr 4, 2025
…-notifier

Co-authored-by: Simon André <smn.andre@gmail.com>
@Kocal
Kocal force-pushed the NotifierMercure branch from b846ad5 to 056eb2c Compare April 4, 2025 17:06
@Kocal

Kocal commented Apr 4, 2025

Copy link
Copy Markdown
Member

Thank you @ernie76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Notify Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants