[Icons] Add support for int/float attribute to ux_icon function

[Kocal]

Q	A
Bug fix?	yes
New feature?	no
Issues	Fix #2148
License	MIT

I'm not really sure why do we have checks on attributes values, do you remember why @kbond? 🙏🏻

[smnandre]

It is not a bug fix..

But i'm fully open to discuss the feature if there is a real usage behind :)

[smnandre]

This works already

<twig:ux:icon height="48" width="64" />

So the problem is when you want to pass some dynamic value (and i really would love to have an example)

<twig:ux:icon height="48" width="{{ 64 / 2 }}" />

But i'm not ok to change it in Icon ... as a SVG tag does not have "float" or "int" values, but only strings.

So maybe we can (string) values in the Renderer :|

[Kocal]

This works already

<twig:ux:icon height="48" width="64" />

So the problem is when you want to pass some dynamic value (and i really would love to have an example)

<twig:ux:icon height="48" width="{{ 64 / 2 }}" />

Yes, that's what is described in issue #2148.

But i'm not ok to change it in Icon ... as a SVG tag does not have "float" or "int" values, but only strings.

In absolute terms, all the values you pass to HTML attributes are strings, but are then interpreted specially.
For example, <input type="range"> which accepts two attributes min and max, you pass strings but they need to be a valid (stringified) number.

But here, we do not speak about the SVG tag but the UX:Icon component instead. Which IMO should behave like other TwigComponent and correctly auto-cast int/string values, ex:

#[AsTwigComponent]
final class AutocastInt
{
    public string $min;
    public int $max;
}

<twig:AutocastInt min="1" max="10" />
<twig:AutocastInt :min="1" :max="10" />
<twig:AutocastInt min="{{ 1 }}" max="{{ 10 }}" />

which renders as expected:

Like in Vue or React/JSX, the following codes are correctly interpreted:

<input type="range" :min="1" max="120" />

<input type="range" min="1" max={10} />

---

Anyway, I don't really understand why do we need such this validation, can't we rely on ComponentAttributes and let it deal with attributes rendering?

[smnandre]

But here, we do not speak about the SVG tag but the UX:Icon component instead. Which IMO should behave like other TwigComponent and correctly auto-cast int/string values, ex:

This is not directly related to the UX:Icon component (that does not really exist, in fact 😓 ) .. so we can either force the string in the Listener, in the Renderer, or ... in the Icon as you did.

But i don't want to store int as "int", but as strings in Icon attributes property.. so what do you prefer ?

[smnandre]

As i said, I agree to cast it, just not internally :)

[smnandre]

Thanks for fixing this bug Hugo.