Skip to content

[Map] Explicitly require StimulusBundle in Bridges, fix tests#2207

Merged
Kocal merged 2 commits intosymfony:2.xfrom
Kocal:fix/map-bridges-tests
Sep 25, 2024
Merged

[Map] Explicitly require StimulusBundle in Bridges, fix tests#2207
Kocal merged 2 commits intosymfony:2.xfrom
Kocal:fix/map-bridges-tests

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Sep 25, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Follows #2180.

When installing a Map Bridge dependencies, the StimulusBundle was not the one from the PR's branch but from 2.x, and so tests didn't fail in #2180 but started to fail after merging:

image

@carsonbot carsonbot added Map Status: Needs Review Needs to be reviewed labels Sep 25, 2024
@Kocal Kocal changed the title [Map] Explicitly require StimulusBundle in Bridges [Map] Explicitly require StimulusBundle in Bridges, fix tests Sep 25, 2024
@Kocal Kocal merged commit e51918f into symfony:2.x Sep 25, 2024
@Kocal Kocal deleted the fix/map-bridges-tests branch September 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Map Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants