Skip to content

[Icons] Support aliases in LockIconsCommand#2356

Merged
smnandre merged 1 commit into
symfony:2.xfrom
smnandre:icons/fix-lock-command-alias
Nov 10, 2024
Merged

[Icons] Support aliases in LockIconsCommand#2356
smnandre merged 1 commit into
symfony:2.xfrom
smnandre:icons/fix-lock-command-alias

Conversation

@smnandre
Copy link
Copy Markdown
Member

@smnandre smnandre commented Nov 9, 2024

Q A
Bug fix? no
New feature? yes
Issues Fix #2354
License MIT

Alias icons are now all locked, and icon set aliases are supported too.

@smnandre
Copy link
Copy Markdown
Member Author

smnandre commented Nov 9, 2024

Test Failures unrelated (JS Map)

@smnandre smnandre requested review from Kocal and kbond and removed request for Kocal November 9, 2024 23:39
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 9, 2024
Copy link
Copy Markdown
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@smnandre smnandre force-pushed the icons/fix-lock-command-alias branch from d68f05b to 9ac91b8 Compare November 10, 2024 00:32
@smnandre smnandre merged commit f329468 into symfony:2.x Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Icons Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icons] Add support for icon aliases during icon:lock command

4 participants