[Autocomplete] Fix handling of associated properties in DQL joins#2377
Merged
Kocal merged 1 commit intosymfony:2.xfrom Nov 28, 2024
Merged
[Autocomplete] Fix handling of associated properties in DQL joins#2377Kocal merged 1 commit intosymfony:2.xfrom
Kocal merged 1 commit intosymfony:2.xfrom
Conversation
Member
|
This seems very legit: do you think you could add a test or two ? |
Contributor
Author
Thank you for the feedback! I’ve already added tests in "Symfony\UX\Autocomplete\Tests\Functional\FieldAutocompleterTest". Let me know if there are fix to add or additional scenarios you'd like me to cover. |
smnandre
approved these changes
Nov 24, 2024
Member
smnandre
left a comment
There was a problem hiding this comment.
Hey @HugoSEIGLE!
Thank you for the added tests!
To be honest I do feel this entire class deserves a big clean / refacto (code style, performance, and code readability)..
But this is way outside the scope of this PR.. that does fix a bug.. so thank you for this and we'll try to refactor it later.
:)
Kocal
approved these changes
Nov 24, 2024
05b0115 to
cc87e60
Compare
Member
|
Thanks Hugo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: