Skip to content

[LiveComponent] Fix checkbox/radio value matching#2401

Merged
smnandre merged 1 commit into
symfony:2.xfrom
smnandre:fix/live-fuzzy-match-values
Nov 23, 2024
Merged

[LiveComponent] Fix checkbox/radio value matching#2401
smnandre merged 1 commit into
symfony:2.xfrom
smnandre:fix/live-fuzzy-match-values

Conversation

@smnandre
Copy link
Copy Markdown
Member

Q A
Bug fix? yes
New feature? no
Issues Fix #...
License MIT

It seems we let some changes appear using linter/formater.. and this time the fuzzy comparaison was intended.

This PR revert those changes to bring back some flexibility and better value matching.

It seems we let some changes appear using linter/formater.. and this time the fuzzy comparaison was intended.

This PR revert those changes to bring back some flexibility and better value matching.
@carsonbot carsonbot added Bug Bug Fix LiveComponent Status: Needs Review Needs to be reviewed labels Nov 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
LiveComponent
live_controller.js 120.36 kB / 23.38 kB 120.13 kB0% / 23.36 kB0%

@smnandre smnandre requested review from Kocal and kbond November 21, 2024 00:09
Copy link
Copy Markdown
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 Thank you

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 21, 2024
@smnandre smnandre merged commit d161d8d into symfony:2.x Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix LiveComponent Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants