[LiveComponent] fix required select not initialized

[dsoriano]

Q	A
Bug fix?	yes
New feature?	no
Issues	Fix #1332
License	MIT

Initialize required select(ChoiceType or EntityType) with the first entry. Not applied to multiple or expanded.

[dsoriano]

If someone knows why ux.symfony.com tests failed... it's gives me headache.. Nothing was changed in the ux.symfony.com directory and in local the tests are ok.

[smnandre]

It appears this PR changes are indeed responsible...

The ux.symfony.com tests on the CI use the UX packages of the PR...

Locally to reproduce you should go into the ux.symfony.com repository and then call the link locally command

cd ux.symfony.com
php bin/link-locally

Then refresh

composer update
php bin/console c:c
symfony server:start -d

[dsoriano]

ok great, thank you ! I will take a look on it.
Weird that locally the tests for ux.symfony.com are ok, but I probably missed something...

Thanks again

[smnandre]

You did not run the php bin/link-locally i suppose ?

I let you look at the suggestion, i found the source of the problem.

I let you check locally and tell me if that seems ok for you ?

[smnandre]

Suggested change

	continue;
	}
	if (\array_key_exists('choices', $child->vars)
	&& $child->vars['required']
	&& !$child->vars['multiple']
	&& !$child->vars['expanded']
	&& null === ($values[$name] ?? null)
	) {
	if (0 === \count($choices = $child->vars['choices'])) {
	throw new UnprocessableEntityHttpException(\sprintf('The required field "%s" is missing and has no default value', $name));
	}
	$values[$name] = reset($choices)->value;
	} else {
	continue;
	}
	// Special handling: required <select> fields with no value, no
	// placeholder and no multiple attribute should have their value set
	// to the first choice, if it exists.
	if (
	\array_key_exists('choices', $child->vars)
	&& $child->vars['required']
	&& !$child->vars['disabled']
	&& !$child->vars['value']
	&& !$child->vars['placeholder']
	&& !$child->vars['multiple']
	&& !$child->vars['expanded']
	&& $child->vars['choices']
	) {
	if (null !== $firstKey = array_key_first($child->vars['choices'])) {
	$values[$name] = $child->vars['choices'][$firstKey]->value ?? null;
	continue;
	}
	}

There were some pre-condition checks missing. This one seems more robust, i'll let you check.

[smnandre]

Suggested change

	'required' => false,
	])
	->add('choice_required', ChoiceType::class, [
	'choices' => [
	'foo' => 1,
	'bar' => 2,
	],
	])
	->add('choice_expanded', ChoiceType::class, [
	'required' => false,
	])
	->add('choice_required_with_placeholder', ChoiceType::class, [
	'choices' => [
	'bar' => 2,
	'foo' => 1,
	],
	'required' => true,
	'placeholder' => 'foo',
	])
	->add('choice_required_without_placeholder', ChoiceType::class, [
	'choices' => [
	'bar' => 2,
	'foo' => 1,
	],
	'required' => true,
	'placeholder' => false,
	])
	->add('choice_expanded', ChoiceType::class, [

I added a test to distinct the two scenarios

[smnandre]

Suggested change

	'choice_required' => '1',
	'choice_expanded' => '',
	'choice_multiple' => ['2'],
	'select_multiple' => ['2'],
	'entity' => (string) $id,
	'choice_required_with_placeholder' => '',
	'choice_required_without_placeholder' => '2',
	'choice_expanded' => '',
	'choice_multiple' => ['2'],
	'select_multiple' => ['2'],
	'entity' => (string) $id,

[dsoriano]

@smnandre indeed I missed the link-locally, thanks for your help. Suggestions was good, all is ok now. Many thanks !

[smnandre]

Thank you very much @dsoriano!

[Kocal]

Thank you Denis and Simon :)