[Icons] Fix LockIconsCommand definition when Iconify disabled

[smnandre]

Q	A
Bug fix?	yes
New feature?	no
Issues	Fix #2415
License	MIT

When iconify is disabled, LockIconsCommand definition is accessed without been set first.

[Kocal]

Thanks for your reactivity Simon, I didn't see anything wrong while merging #2410 😅

It would be really nice to have E2E/smoke tests that will create a new Symfony app, install the component, and see what happens

[smnandre]

Thanks for your reactivity Simon, I didn't see anything wrong while merging #2410 😅

It would be really nice to have E2E/smoke tests that will create a new Symfony app, install the component, and see what happens

This one is 100% on me, did not check enough when i updated the extension.

[smnandre]

It would be really nice to have E2E/smoke tests that will create a new Symfony app, install the component, and see what happens

This would not have detected the problem here, as you need to disable iconify to trigger it.

But that mean we are far from having enough fonctional test.

[javiereguiluz]

Thanks Simon.

[trsteel88]

@javiereguiluz is it possible to get this tagged? It's currently breaking all our applications.

Thanks.

[Kocal]

@trsteel88 you can pin symfony/ux-icons at version 2.21.0 for the moment.

@kbond ideally we want to tag a new release after #2420 too 🙏🏻