[Map] Fix default values of Stimulus Map Controller#2420
Merged
Kocal merged 1 commit intosymfony:2.xfrom Dec 3, 2024
Merged
Conversation
Contributor
📊 Packages dist files size differenceℹ️ No difference in dist packagesFiles. |
Member
Author
|
Should be better now, TIL Stimulus values' default value does not behave like Vue props' default value 😅 I reverted my changes and used |
6b0847e to
0e1bbf4
Compare
kbond
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue happens at
doCreateMapwhen we called->fitBoundsToMarkers()instead of->center(...).The value
centerwas supposed to benull, but since I forgot to configure the default value ofthis.centerValuetonull, it automatically used{}as default value (https://stimulus.hotwired.dev/reference/values#getters) and it breaks the code.This bug has been introduced in #2385.