[Stimulus] Fasten lazy loading + add debug lazy:loading and lazy:loaded #2463
Merged
Conversation
Contributor
📊 Packages dist files size differenceℹ️ No difference in dist packagesFiles. |
Member
I will try to find some time to rebuild a Symfony + Encore app, but by reading your changes it looks fine to me (feel free to reping me if necessary) |
Member
Author
|
@MatTheCat ? 👼 |
Member
|
I'm testing |
Member
|
Well... I've just realized, but to use Stimulus in a Symfony App with Webpack Encore, we use the https://github.com/symfony/stimulus-bridge ... which is not in this repository (and so not modified by this PR) 😅 |
Kocal
approved these changes
Dec 22, 2024
carsonbot
added
Status: Reviewed
Member
Author
|
Well.... let me tell you i have no intention of coding in the Bridge hahaha (i'll have a look but the lazy loading is done differently if i remember correctly) |
Contributor
|
I’ve got nothing to test then? 🤔 |
carsonbot
added
Status: Needs Review
Kocal
force-pushed
the
stimulus/lazy-loader
branch
from
0e5abca to
3b8e1ce
Compare
Member
|
Thanks Simon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR..
improves the controller lazy loading by tuning algorithm (early exit, remove await, ...)
introduces two new debug events in the console to ease DX with lazy controllers
my-controller#lazy:loadingwhen the lazy controller is detected in the DOMmy-controller#lazy:loadedafter the file has been downloaded and importedI would really like some feedback / tests IRL (especially with Webpack i'm not used to)