[Map] Add new helpers: DistanceUnit, DistanceCalculator, CoordinateUtils#2551
Merged
Merged
Conversation
carsonbot
added
Feature
Kocal
approved these changes
Feb 6, 2025
carsonbot
added
Status: Reviewed
smnandre
force-pushed
the
map/distance-unit-calculator
branch
from
48a2c88 to
381bc6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ease the work on distances while managing maps, this PR introduce some new tools
DistanceUnitenum, that contains the most common distance units and their conversion ratiosDistanceCalculatorInterface, and 3 implementations (most commonly used formulas)DistanceCalculatorfinal service, that defaults to Vincenty formula and Meter unitCoordinateUtilshelper to convert DMS coordinates (48° 7′ 3″ N) in decimal ones (48.1175 N)Also, added
getLatitude()andgetLongitude()onPoint, avoiding the use of toArray()