Skip to content

fix missing }, reformat so it's visible#2599

Merged
Kocal merged 1 commit into
symfony:2.xfrom
tacman:patch-6
Feb 24, 2025
Merged

fix missing }, reformat so it's visible#2599
Kocal merged 1 commit into
symfony:2.xfrom
tacman:patch-6

Conversation

@tacman

@tacman tacman commented Feb 24, 2025

Copy link
Copy Markdown
Contributor
<div {{ stimulus_controller('chart',
            { 'name': 'Likes', 'data': [1, 2, 3, 4] }, 
            { 'loading': 'spinner' }, 
            { 'other': '.target' } ) }}>

Currently, the 'outlet' part is cut off:

image

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 24, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 24, 2025
@Kocal Kocal added Documentation Improvements or additions to documentation and removed Status: Reviewed Has been reviewed by a maintainer labels Feb 24, 2025
Comment thread src/StimulusBundle/doc/index.rst Outdated
Hello
</div>


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

```twig
<div {{ stimulus_controller('chart',
            { 'name': 'Likes', 'data': [1, 2, 3, 4] },
            { 'loading': 'spinner' },
            { 'other': '.target' } ) }}>
```
@Kocal

Kocal commented Feb 24, 2025

Copy link
Copy Markdown
Member

Thank you @tacman.

@Kocal Kocal merged commit 80788f7 into symfony:2.x Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants