[Map] Make renderer tests way easier to maintain, use snapshots

[Kocal]

Q	A
Bug fix?	no
New feature?	no
Docs?	no
Issues	Fix #...
License	MIT

[Kocal]

PHP Fatal error: Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /home/runner/work/ux/ux/src/Map/src/Bridge/Google/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 327

Well, let's move from Symfony's PHPUnit bridge, see #2659

EDIT: let's upgrade Map's Bridges PHPUnit to 11.5.0, that's more simple :D

[Copilot]

Copilot reviewed 10 out of 30 changed files in this pull request and generated no comments.

Files not reviewed (20)

• src/Map/src/Bridge/Google/composer.json: Language not supported
• src/Map/src/Bridge/Google/phpunit.xml.dist: Language not supported
• src/Map/src/Bridge/Google/tests/GoogleRendererTest.php: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set markers with icons__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set simple map, with minimum options__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with all markers removed__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with controls enabled__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with custom attributes__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with default map id overridden by option mapId__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with default map id, when passing options (except the mapId)__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with default map id__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with every options__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with marker remove and new ones added__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with markers and infoWindows__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with polygons and infoWindows__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set with polylines and infoWindows__1.txt: Language not supported
• src/Map/src/Bridge/Google/tests/snapshots/GoogleRendererTest__testRenderMap with data set without controls enabled__1.txt: Language not supported
• src/Map/src/Bridge/Leaflet/composer.json: Language not supported
• src/Map/src/Bridge/Leaflet/phpunit.xml.dist: Language not supported
• src/Map/src/Bridge/Leaflet/tests/LeafletRendererTest.php: Language not supported

[kbond]

Cool, I've never used snapshots before.

[Kocal]

Cool, I've never used snapshots before.

I think it's something that was made popular years ago with JavaScript, especially with Jest.
Snapshots should be used cautiously, but in this case where we want to quickly assert that outputs didn't change whatever changes we do, that's fine 💯