[LiveComponent] fix: LiveComponentHydrator::hydrateValue() cannot hydrate null values - #2730
Merged
Merged
Conversation
nikophil
changed the title
LiveComponentHydrator::hydrateValue() cannot hydrate null values
nikophil
force-pushed
the
fix/allow-hydrate-null-values
branch
from
May 13, 2025 09:37
4c9db58 to
e918dd8
Compare
kbond
approved these changes
May 13, 2025
carsonbot
added
Status: Reviewed
Kocal
approved these changes
May 13, 2025
Kocal
left a comment
Kocal
left a comment
Member
There was a problem hiding this comment.
Thanks!
Can you mention this fix in the changelog? 🙏🏻
Contributor
Author
|
will you release it in 2.24.1 or 2.25.0? just to know how I should update the changelog |
Member
|
2.25.0 |
nikophil
force-pushed
the
fix/allow-hydrate-null-values
branch
from
May 13, 2025 12:28
e918dd8 to
8d88ccb
Compare
Contributor
Author
|
done |
Member
|
Thank you @nikophil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
such live prop cannot currently be hydrated by
LiveComponentHydrator::hydrateValue()because nullability is not handled and the serializer is asked to deserializenullintoMyDTOthis PR fixes this problem
NB: all the failures in the CI are unrelated to this fix