Homogenize PHP-CS-Fixer configuration with symfony/symfony, and run it - #2768
Merged
Conversation
Kocal
commented
May 23, 2025
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | no |
| Issues | Fix #... |
| License | MIT |
Member
Author
|
Interesting, because PHP-CS-Fixer changed: for: The following error now happens: That's weird, I would expect |
Kocal
force-pushed
the
chore/run-php-cs-fixer
branch
from
May 24, 2025 05:58
cf1862a to
b150af3
Compare
smnandre
reviewed
May 24, 2025
smnandre
reviewed
May 24, 2025
smnandre
reviewed
May 24, 2025
smnandre
reviewed
May 24, 2025
smnandre
left a comment
Member
There was a problem hiding this comment.
Yep, always some troubles with anonymous classes in test & php-cs-fixer ..
For the rest, thanks!
Kocal
force-pushed
the
chore/run-php-cs-fixer
branch
from
May 24, 2025 17:18
b150af3 to
4f44267
Compare
Member
Author
|
Thanks for the review @smnandre 🙏🏻 it should be better now! |
smnandre
reviewed
May 24, 2025
| return (new PhpCsFixer\Config()) | ||
| ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect()) | ||
| ->setRules([ | ||
| '@PHP71Migration' => true, |
Member
There was a problem hiding this comment.
Not sure we need this addition ?
smnandre
reviewed
May 24, 2025
smnandre
approved these changes
May 24, 2025
Kocal
force-pushed
the
chore/run-php-cs-fixer
branch
from
May 26, 2025 06:21
4f44267 to
8c1cdf4
Compare
Kocal
force-pushed
the
chore/run-php-cs-fixer
branch
from
May 26, 2025 06:21
8c1cdf4 to
cefa074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
