Skip to content

[Map] Remove invalid marker icon example - #2771

Merged
Kocal merged 1 commit into
symfony:2.xfrom
insiders:map-marker-icon-docs
May 26, 2025
Merged

[Map] Remove invalid marker icon example#2771
Kocal merged 1 commit into
symfony:2.xfrom
insiders:map-marker-icon-docs

Conversation

@dannyvw

@dannyvw dannyvw commented May 25, 2025

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

This icon example is invalid and is better described under "Add marker icons".

@dannyvw
dannyvw requested a review from Kocal as a code owner May 25, 2025 11:55
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Bug Bug Fix Map labels May 25, 2025
@carsonbot

Copy link
Copy Markdown

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@Kocal

Kocal commented May 26, 2025

Copy link
Copy Markdown
Member

Oh, thanks, I forgot this example when working on Marker icons.

@Kocal Kocal added Documentation Improvements or additions to documentation and removed Bug Bug Fix labels May 26, 2025
@Kocal

Kocal commented May 26, 2025

Copy link
Copy Markdown
Member

Thank you @dannyvw.

@Kocal
Kocal merged commit 2b2d180 into symfony:2.x May 26, 2025
@dannyvw
dannyvw deleted the map-marker-icon-docs branch May 26, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Map Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants