Skip to content

[Map] Optional leaflet tilelayer - #2779

Merged
Kocal merged 1 commit into
symfony:2.xfrom
insiders:map-tilelayer
May 28, 2025
Merged

[Map] Optional leaflet tilelayer#2779
Kocal merged 1 commit into
symfony:2.xfrom
insiders:map-tilelayer

Conversation

@dannyvw

@dannyvw dannyvw commented May 28, 2025

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #...
License MIT

Comment from #2445 (comment)

@dannyvw
dannyvw requested a review from Kocal as a code owner May 28, 2025 09:32
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Map labels May 28, 2025
@carsonbot

Copy link
Copy Markdown

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@github-actions

github-actions Bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map (Bridge Leaflet)
map_controller.d.ts 2.03 kB / 667 B 2.04 kB0% / 672 B+1% 📈
map_controller.js 9.65 kB / 2.58 kB 9.71 kB+1% 📈 / 2.59 kB0%

@Kocal Kocal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a new feature, can you add a changelog entry? 🙏🏻

Comment thread src/Map/src/Bridge/Leaflet/assets/src/map_controller.ts
@Kocal

Kocal commented May 28, 2025

Copy link
Copy Markdown
Member

Changelog and documentation updated

@Kocal Kocal added the Feature New Feature label May 28, 2025
@Kocal

Kocal commented May 28, 2025

Copy link
Copy Markdown
Member

Thank you @dannyvw.

@Kocal
Kocal merged commit 825476f into symfony:2.x May 28, 2025
@Kocal
Kocal deleted the map-tilelayer branch May 28, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Map Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants