[TwigComponent] Fix escaping of Alpine.js attribute keys containing numeric characters#2833
Merged
Conversation
carsonbot
added
Bug
Kocal
approved these changes
Jun 13, 2025
Kocal
left a comment
Kocal
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix!
Can you update ComponentAttributesTest test to prevent any regressions on this?
carsonbot
added
Status: Reviewed
Contributor
Author
Sorry missed that part, I will do that asap. |
carsonbot
added
Status: Needs Review
Kocal
approved these changes
Jun 13, 2025
carsonbot
added
Status: Reviewed
…umeric characters
Member
|
Thank you @klausi85. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine.js attribute keys like
@input.debounce.500ms(see https://alpinejs.dev/directives/on#debounce) will now be correctly handled without being escaped.