Run JS tests under multiple JS versions, define .nvmrc to 22.6 - #2865
Merged
Conversation
Kocal
added a commit
that referenced
this pull request
Jun 28, 2025
This PR was merged into the 2.x branch. Discussion ---------- Migrate `bin/*.js` to TypeScript, use `tsx` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Types ✨ Following #2865, in fact I didn't go with Node & `--experimental-strip-types` flag, but with https://tsx.is/ instead. Commits ------- a0103b4 Migrate `bin/*.js` to TypeScript, use `tsx`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a second PR, I want to be able to run TypeScript natively with Node.js, for
bin/*.jsscripts. This is doable with Node.js 22.6+ with--experimental-strip-types example.tsflag, see https://nodejs.org/en/learn/typescript/run-natively.I'm configuring the version through
.nvmrc(related to https://github.com/nvm-sh/nvm) instead of specifying it inpackage.jsonengines.node, otherwise it became an hard requirement making us impossible to run Node.js <22 (making impossible to run our JS tests for different major Node.js releases like 18 and 20).