Replace Yarn Berry by PNPM#2932
Merged
Merged
Conversation
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
Kocal
commented
Jul 20, 2025
| - name: Replace local "workspace:*" occurrences | ||
| run: | | ||
| yarn workspaces foreach -pA exec "sed -i 's/\"workspace:\*\"/\"${{ env.VERSION }}\"/g' package.json" | ||
|
|
Member
Author
There was a problem hiding this comment.
This is automatically done when running pnpm publish, see https://pnpm.io/workspaces#publishing-workspace-packages
Kocal
force-pushed
the
move-from-yarn-to-pnpm
branch
7 times, most recently
from
July 21, 2025 06:59
1eef72b to
548ae06
Compare
Kocal
commented
Jul 21, 2025
| "@testing-library/dom": "^10.4.0", | ||
| "@testing-library/jest-dom": "^6.6.3", | ||
| "@testing-library/user-event": "^14.6.1", | ||
| "@testing-library/dom": "catalog:", |
Member
Author
There was a problem hiding this comment.
Catalogs are like an alias to a constraint version.
When defining the catalog version for @testing-library/dom, then it will always install the exact same version when installing the same package in different places (if we use the same catalog ofc)
Kocal
commented
Jul 21, 2025
Comment on lines
+52
to
+60
| "@testing-library/dom": "catalog:", | ||
| "@testing-library/jest-dom": "catalog:", | ||
| "@testing-library/user-event": "catalog:", | ||
| "jsdom": "catalog:", | ||
| "tom-select": "^2.2.2", | ||
| "tslib": "catalog:", | ||
| "tsx": "catalog:", | ||
| "typescript": "catalog:", | ||
| "vitest": "catalog:", |
Member
Author
There was a problem hiding this comment.
Adding the (dev) dependencies used by the package instead of relying of packages installed from parents directories (that "magically" works with Yarn) is a good practice.
By using catalog:, we will have the same exact version of the dependency installed everywhere (consistency).
Kocal
commented
Jul 21, 2025
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| /// <reference types="@types/webpack-env" /> |
Member
Author
There was a problem hiding this comment.
Otherwise __WebpackModuleApi was not found
Kocal
commented
Jul 21, 2025
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| /// <reference types="google.maps" /> |
Member
Author
There was a problem hiding this comment.
Otherwise google type was not found
Kocal
force-pushed
the
move-from-yarn-to-pnpm
branch
from
July 21, 2025 07:07
548ae06 to
d25f4cb
Compare
Kocal
force-pushed
the
move-from-yarn-to-pnpm
branch
from
July 21, 2025 08:06
d25f4cb to
17a4bb7
Compare
Kocal
commented
Jul 21, 2025
| YARN_ENABLE_HARDENED_MODE: 0 | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: 0 | ||
| - working-directory: test_apps/encore-app | ||
| run: pnpm install --ignore-workspace |
Member
Author
There was a problem hiding this comment.
--ignore-workspace allows to ignore the pnpm-workspace.yaml from parent folders, and install dependencies from test_apps/encore-app only (test_apps/encore-app is not a workspace on purpose)
Member
|
What does it mean for the contributors? |
Member
|
Nice job and i’m all in to leave legacy yarn :) |
Member
Author
pnpm will be automatically installed when running |
kbond
approved these changes
Jul 21, 2025
kbond
left a comment
kbond
left a comment
Member
There was a problem hiding this comment.
Good arguments for this change!
carsonbot
added
Status: Reviewed
Kocal
added a commit
that referenced
this pull request
Jul 28, 2025
…PM, as it breaks installation from `vendor/` PHP packages (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #2951 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Since #2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Jul 28, 2025
…from PNPM, as it breaks installation from `vendor/` PHP packages (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix symfony#2951 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Since symfony#2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Jul 28, 2025
…from PNPM, as it breaks installation from `vendor/` PHP packages (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix symfony#2951 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Since symfony#2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purely internal, this PR replaces Yarn by PNPM for the following reasons:
For developers working on UX, pnpm can be installed with Corepack
Note: the ~26k lines changed are mainly about lock files