[Toolkit][Badge] Remove hover style to clearly distinguish from Button #3197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
toolkit-badge-remove-hover_style
branch
from
a77470f to
f14635b
Compare
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Nov 29, 2025
…nguish from Button (Tassilo Gröper) This PR was merged into the 2.x branch. Discussion ---------- [Toolkit][Badge] Remove hover style to clearly distinguish from Button | Q | A | -------------- | --- | Bug fix? | yes | New feature? | no | Deprecations? | no | Documentation? | no | Issues | | License | MIT Confusion may occur, if the badge shows a different style on mouse hover. As it is not a button, we need to remove it. Additionally, the badge component on Shadcn does not hold hover styles, when interacted with a mouse. see https://ui.shadcn.com/docs/components/badge Commits ------- f14635b [Toolkit][Badge] Remove hover style to clearly distinguish badge from button
Member
|
Thanks @tassilogroeper! |
Kocal
added a commit
that referenced
this pull request
Nov 30, 2025
* 2.x: bug #3197 [Toolkit][Badge] Remove hover style to clearly distinguish from Button (Tassilo Gröper) [Toolkit][Kdb] Add new component kdb from shadcn ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusion may occur, if the badge shows a different style on mouse hover. As it is not a button, we need to remove it.
Additionally, the badge component on Shadcn does not hold hover styles, when interacted with a mouse. see https://ui.shadcn.com/docs/components/badge