Skip to content

Remove deprecated controller_resolver configuration and update Doctrine ORM settings #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
Merged

Remove deprecated controller_resolver configuration and update Doctrine ORM settings #3199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/.utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ live_component_post_install() {
return $?
;;
8.4)
# Install PropertyInfo 7.3 (deprecate PropertyTypeExtractorInterface::getTypes) and TypeInfo 7.3 (new features and deprecations)
composer require symfony/property-info:7.3.* symfony/type-info:7.3.*
# Install PropertyInfo 7.4 (deprecate PropertyTypeExtractorInterface::getTypes from 7.3) and TypeInfo 7.4, but for Symfony 8 compatibility
composer require symfony/property-info:7.4.* symfony/type-info:7.4.*
return $?
;;
esac
Expand Down
9 changes: 6 additions & 3 deletions src/Autocomplete/tests/Fixtures/Kernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,19 @@ protected function configureContainer(ContainerConfigurator $c): void
'alias' => 'Test',
],
],
'controller_resolver' => [
'auto_mapping' => false,
],
],
];

if (null !== $doctrineBundleVersion = InstalledVersions::getVersion('doctrine/doctrine-bundle')) {
if (version_compare($doctrineBundleVersion, '3.0.0', '<')) {
$doctrineConfig['orm']['auto_generate_proxy_classes'] = true;

// https://github.com/doctrine/DoctrineBundle/pull/1661
// https://github.com/doctrine/DoctrineBundle/pull/1962
if (version_compare($doctrineBundleVersion, '2.9.0', '>=')) {
$doctrineConfig['orm']['report_fields_where_declared'] = true;
}

if (version_compare($doctrineBundleVersion, '2.12.0', '>=')) {
$doctrineConfig['orm']['controller_resolver']['auto_mapping'] = true;
}
Expand Down
9 changes: 0 additions & 9 deletions src/LiveComponent/tests/Fixtures/Kernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ protected function configureContainer(ContainerConfigurator $c): void
'alias' => 'XML',
],
],
'controller_resolver' => [
'auto_mapping' => false,
],
],
];

Expand All @@ -201,12 +198,6 @@ protected function configureContainer(ContainerConfigurator $c): void
}
}

// https://github.com/doctrine/DoctrineBundle/pull/1661
if (version_compare($doctrineBundleVersion, '2.9.0', '>=')) {
$doctrineConfig['orm']['validate_xml_mapping'] = true;
$doctrineConfig['dbal']['schema_manager_factory'] = 'doctrine.dbal.default_schema_manager_factory';
}

if (\PHP_VERSION_ID >= 80400 && version_compare($doctrineBundleVersion, '2.15.0', '>=') && version_compare($doctrineBundleVersion, '4.0.0', '<')) {
$doctrineConfig['orm']['enable_native_lazy_objects'] = true;
}
Expand Down
Loading