Permalink
Commits on Jan 3, 2019
  1. bug #29755 Improved BIC + IBAN validator for some special cases (javi…

    nicolas-grekas committed Jan 3, 2019
    …ereguiluz)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes #29755).
    
    Discussion
    ----------
    
    Improved BIC + IBAN validator for some special cases
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    While blogging about [Improved Financial Constraints in Symfony 4.3](https://symfony.com/blog/new-in-symfony-4-3-improved-financial-constraints) I found this resource that mentions some exceptions when validating BIC + IBAN: https://wiki.xmldation.com/index.php?title=Support/EPC/IBAN_%26_BIC_relation
    
    I don't know if that resource is fully reliable ... but I checked it in the official "European Banking Resources" website (https://www.ecbs.org/iban/) and most of it matches, so I think we can safely make this change.
    
    Commits
    -------
    
    88a1696a64 Improved BIC + IBAN validator for some special cases