Skip to content
Permalink
Branch: master
Commits on Jul 11, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Jul 11, 2019
    * 4.4:
      Rename ErrorCatcher to ErrorRenderer (rendering part only)
  2. Merge branch '4.4'

    nicolas-grekas committed Jul 11, 2019
    * 4.4: (53 commits)
      Fix Twig 1.x compatibility
      Deprecating templateExists method
      [Translator] Improve farsi(persian) translations for Form
      [Validator] Fix Changelog for #31511
      [Lock][Console] bump lock requirement in console
      [Lock] minor: add missing alias for PersistenStoreInterface
      Improve fa translations
      Dynamic bundle assets
      [Lock] rename and deprecate Factory into LockFactory
      [Debug] Restoring back the state of the Debug component (1st step)
      Spell "triggering" properly
      [Lock] Fix tests
      Added tests to cover the possibility of having scalars as services.
      fixed CS
      [Lock] Split \"StoreInterface\" into multiple interfaces with less responsability
      [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit
      [Validator] Allow to use property paths to get limits in range constraint
      Fix missing deprecations
      fixed tests on old PHP versions
      [FrameworkBundle] Inform the user when save_path will be ignored
      ...
Commits on Jul 9, 2019
  1. minor #32377 [Debug] Restoring back the state of the Debug component …

    nicolas-grekas committed Jul 9, 2019
    …(1st step) (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32377).
    
    Discussion
    ----------
    
    [Debug] Restoring back the state of the Debug component (1st step)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#32371
    | License       | MIT
    
    After a good discussion with @nicolas-grekas, we made the decision to split the current `ErrorCatcher` component into several:
     * `ErrorHandler` it would be the Debug component before these changes symfony/symfony#31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name.
     * `ErrorDumper` it would be the current ErrorCatcher but with FlattenException + the new error renderer system only.
    
    This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components, **BUT without moving any code !!**, that would give us more freedom to do it correctly in the new components.
    
    NOTE: For this PR I've copy the `Debug` component directory from the revision prior to merged commit  symfony/symfony#31065 in 4.4 branch.
    
    Commits
    -------
    
    eda49e295e [Debug] Restoring back the state of the Debug component (1st step)
You can’t perform that action at this time.