Do not allow webpack-dev-server to find an open port #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunate, as this is a nice feature of webpack-dev-server where if port 8080 is open, it will try 8081, etc. However, because we need to build a manifest.json file, we need to know what the port is for sure at Webpack config build time. Even going through the same async process of using the "find-port" package isn't really doable... as it would make the entire config generation async (this may be possible, but would change a ton of things in Encore).
stof
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses on issue on #941
This disallows the "find an open port" feature in webpack-dev-server. This is unfortunate, as this is a nice feature of webpack-dev-server where if port 8080 is open, it will try 8081, etc.
However, because we need to build a manifest.json file, we need to know what
the port is for sure at Webpack config build time. Even going through the same
async process of using the "find-port" package isn't really doable... as it
would make the entire config generation async (this may be possible, but would
change a ton of things in Encore & in userland
webpack.config.jsfiles).Cheers!