Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SymfonyConnect #29

Merged

Conversation

Projects
None yet
3 participants
@azjezz
Copy link
Contributor

commented Jul 4, 2019

rebase of #28

@@ -1,6 +1,6 @@
<?php
namespace SensioLabs\Bundle\ConnectBundle\Collector;
namespace SymfonyCorp\Bundle\ConnectBundle\Collector;
use Buzz\Listener\ListenerInterface;

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jul 5, 2019

Contributor

how do we decouple from this namespace so that this is compatible with symfonycorp/connect 5.1?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jul 8, 2019

Contributor

I'm merging to help move forward, but could you please have a look at this @azjezz please?

This comment has been minimized.

Copy link
@azjezz

azjezz Jul 8, 2019

Author Contributor

sure 👍

This comment has been minimized.

Copy link
@nicolas-grekas
@nicolas-grekas

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Thank you @azjezz.

@nicolas-grekas nicolas-grekas merged commit 6322fac into symfonycorp:master Jul 8, 2019

nicolas-grekas added a commit that referenced this pull request Jul 8, 2019

feature #29 Migrate to SymfonyConnect (tucksaun)
This PR was merged into the 4.x-dev branch.

Discussion
----------

Migrate to SymfonyConnect

rebase of #28

Commits
-------

6322fac Migrate to SymfonyConnect
@nicolas-grekas

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Thank you @tucksaun too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.