Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clubs and projects's features #70

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@JJarrie
Copy link
Contributor

commented May 23, 2019

No description provided.

@JJarrie JJarrie force-pushed the JJarrie:remove-clubs-projects branch 3 times, most recently from 5d91526 to 6fd4422 May 23, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

(rebase needed)

@JJarrie JJarrie force-pushed the JJarrie:remove-clubs-projects branch 3 times, most recently from 9ce28ac to ec99c3d Jun 6, 2019

@JJarrie JJarrie force-pushed the JJarrie:remove-clubs-projects branch 4 times, most recently from cee9f82 to c47db79 Jun 6, 2019

@nicolas-grekas
Copy link
Contributor

left a comment

last comments I think

@@ -53,6 +52,10 @@ public function getRoles()
return $this->getUserRoles($user);
}
if (method_exists(AbstractToken::class, 'getRoleNames')) {

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 7, 2019

Contributor

all the BC layers should be moved to a PR on 4.3!

@@ -47,9 +47,6 @@ public function testAccessTokenAccessorsAndMutators()
$this->assertNull($this->api->getAccessToken());
}
/**
* @group legacy

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 7, 2019

Contributor

all these should be removed in 4.3, they cannot be legit if the test case doesn't change

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Rebase + squash needed please.

@JJarrie JJarrie force-pushed the JJarrie:remove-clubs-projects branch 2 times, most recently from 2f96d16 to a43c056 Jun 10, 2019

@JJarrie JJarrie force-pushed the JJarrie:remove-clubs-projects branch from a43c056 to 2b53166 Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.